A function with two datetime parameters receives the string '00:00:00.000000' for the second argument

Describe the bug

Register a function with two parameters, both of type DataType.time. The second argument passed to the function implementation is never the argument passed in the SQL, it is always the string ‘00:00:00.000000’.

To Reproduce

This test fails (I poked it into function-calls.spec.ts):

    it('passes multiple arguments', () => {
        db.public.registerFunction({
            name: 'datediff',
            args: [DataType.time, DataType.time],
            returns: DataType.integer,
            implementation: (arg1, arg2) => {
                assert.instanceOf(arg1, Date);
                assert.instanceOf(arg2, Date);
                return Math.trunc(arg1 / 86400) - Math.trunc(arg2 / 86400);
            },
        });

        expect(many(`select datediff(date '2008-03-13', date '2008-02-12')`))
            .to.equal(29);
    });

with the assertion failure:

  1) Functions
       passes multiple arguments:
     AssertionError: expected '00:00:00.000000' to be an instance of Date

pg-mem version

2.4.3 (and tip of master branch)

[gthb]

Right, this was PEBKAC — see, I’m implementing a different SQL dialect, translating into PostgreSQL to use pg-mem underneath, and the other dialect calls the time-of-day type timeofday and the date-time type time, and I totally tripped on my shoelaces juggling these differences in my head 😁 … thanks!

[oguimbal]

The issue with cast should be fixed in pg-mem@2.5.0