knex onConflict merge with columns

Describe the bug

When using createKnex adapter, we have an issue with queries that do upsert on selected columns. merge without specifying columns is working fine.

Column "0" not found

To Reproduce

const data = [
        { id: 1, other_id: 111, some_field: 'value', created_at: new Date(), updated_at: new Date() },
        { id: 2, other_id: 222, some_field: 'value2', created_at: new Date(), updated_at: new Date() }
    ];
    const query = knex('example').insert(data).onConflict(['id', 'other_id']).merge(['updated_at', 'some_field']);
    console.log(query.toSQL());

it will produce do update set “0” = ?,“1” = ?’ should be do update set “some_field” = excluded.“some_field”, “updated_at” = excluded.“updated_at”’

{
  method: 'insert',
  options: {},
  timeout: false,
  cancelOnTimeout: false,
  bindings: [
    2022-01-31T21:17:53.130Z,
    1,
    111,
    'value',
    2022-01-31T21:17:53.130Z,
    2022-01-31T21:17:53.130Z,
    2,
    222,
    'value2',
    2022-01-31T21:17:53.130Z,
    'updated_at',
    'some_field'
  ],
  __knexQueryUid: 'lwEt8xzcV2xKl87iZdJQl',
  sql: 'insert into "example" ("created_at", "id", "other_id", "some_field", "updated_at") values (?, ?, ?, ?, ?), (?, ?, ?, ?, ?) on conflict ("id", "other_id") do update set "0" = ?,"1" = ?',
  returning: undefined
}

pg-mem version

2.3.0

[elad-sf]

you are right… node_modules/knex version is:

"type": "version",
"version": "0.21.19"

I still waiting for npm to update pg-mem to 2.3.2, it’s still on 2.3.1 and will keep you updated. thanks!

[oguimbal]

No problem !