Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add type hints to opentelemetry-sdk and run as a part of tests

See original GitHub issue

Much of opentelemetry-sdk code doesn’t have type hints. It would be great to add mypy type hints and run the tests similar to opentelemetry-api.

Issue Analytics

State:
Created 3 years ago
Reactions:4
Comments:14 (8 by maintainers)

Top GitHub Comments

2reactions

aceberlecommented, Mar 23, 2022

Thank you so much @srikanthccv, I added that to my configuration and now mypy is able to resolve all of the imports from opentelemetry-python!

1reaction

dmolenda-sumocommented, May 4, 2021

Yes, I do. I’ve been a little busy recently, but I hope to finish this task soon

Top Results From Across the Web

Tests aren't enough: Case study after ... - Seth Michael Larson

Our solution to this was to maintain a list of files in our project that we knew had correct type hints. Mypy would...

Add type hints and expose them via PEP561 #1112 - GitHub

This issue is done when the following criteria are met: Type hinting is part of CI under the lint environment in the tox.ini...

Type hints cheat sheet - mypy 0.991 documentation

Type hints cheat sheet#. This document is a quick cheat sheet showing how to use type annotations for various common types in Python....

Migrating from Jaeger Java client to OpenTelemetry SDK

This guide will help you with your first steps in migrating to OpenTelemetry SDK from Jaeger for your application instrumented using the ...

Manual Instrumentation | OpenTelemetry

This can be done using the OpenTelemetrySdk.builder() method. ... in particular the service.name attribute is the most important piece of telemetry ...