question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Exporters shouldn't have service name parameter

See original GitHub issue

Exporters jaeger, zipkin and opencensus accept an argument service_name but ideally they should rely on the Resource’s service.name attribute from Tracer/Span to indicate the resource that produced the corresponding telemetry.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:2
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
srikanthccvcommented, Feb 25, 2021

Should we remove service.name from the constructors of exporters too?

Yes, that’s what I mentioned in the issue title, I hope that’s conveying the same? We need to remove the service_name param and use the Resource attribute.

1reaction
dmararcommented, Feb 22, 2021

@lonewolf3739 , Just to clarify on the requirement: consider the following export() function of jaeger:

def export(self, spans) -> SpanExportResult:
>       service_name = spans[0].resource.service.name if spans[0].resource  else None  #assuming that all spans in a batch will have same resource.service.name

        translator = Translate(spans)
        if self.transport_format == TRANSPORT_FORMAT_PROTOBUF:
>            pb_translator = ProtobufTranslator(**service_name**)
            jaeger_spans = translator._translate(pb_translator)
            batch = model_pb2.Batch(spans=jaeger_spans)
            request = PostSpansRequest(batch=batch)
....
Read more comments on GitHub >

github_iconTop Results From Across the Web

webpack - Error: Should not import the named export 'version ...
As of Webpack 5 the named export is deprecated which mirrors the behaviour of node. To work around use in webpack config: ignoreWarnings:...
Read more >
Writing exporters - Prometheus.io
Metric names should not include the labels that they're exported with, e.g. by_type , as that won't make sense if the label is...
Read more >
OpenTelemetry Environment Variable Specification
The goal of this specification is to unify the environment variable names between different OpenTelemetry SDK implementations.
Read more >
export PATH ( ';' PARAMETER )* ( ',' PATH ( ';' - bnd
name – Overrides the default name of the output file. It should contain the extension. The file should not have path segments, it...
Read more >
Reports - Export To File - REST API (Power ... - Microsoft Learn
Exports the specified report from My workspace to the requested file ... Service: Power BI REST APIs ... Data contract for paginated report...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found