Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BUG]: `render_json` should only accept Dict/TypeDict type of values.

See original GitHub issue

Describe the bug

In some places of the codebase, we are passing list type of values to the render_json method which forces us to use broader type for the arguments of render_json.

Places where these list values are passed: https://github.com/oppia/oppia/blob/f8a8d680c6f95dfc3c63a003484177ac06e4ce21/core/controllers/learner_group.py#L954 https://github.com/oppia/oppia/blob/f8a8d680c6f95dfc3c63a003484177ac06e4ce21/core/controllers/learner_group.py#L314

Expected Behavior

render_json method should only accept Dict/TypedDict values not list types of values.

Issue Analytics

State:
Created 10 months ago
Comments:6 (2 by maintainers)

Top GitHub Comments

1reaction

Ashism766commented, Nov 23, 2022

Ok understood, Thanks for responding.

On Wed, 23 Nov 2022, 17:32 sahil jhangar, @.***> wrote:

is oppia* going to participate in gsoc 2023?

Really sorry @Ashism766 https://github.com/Ashism766, I have no clue about this one.

how many contributions I should have in oopia so i can be a member in gsoc oopia?

From my perspective, there is only one criterion, quality contributions to the organization.

— Reply to this email directly, view it on GitHub https://github.com/oppia/oppia/issues/16539#issuecomment-1324953100, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATRI3BUCCCXNBTHKJ4KKVWDWJYBWPANCNFSM6AAAAAAR7PAVUY . You are receiving this because you were mentioned.Message ID: @.***>