Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Lint check reports same error twice

See original GitHub issue

Lint error reports and even counts the same error twice(See screenshot below).

Steps to reproduce:

Change describe to fdescribe in any *Spec.js file
Run python scripts/pre_commit_linter.py
See error log.

Issue Analytics

State:
Created 4 years ago
Comments:11 (10 by maintainers)

Top GitHub Comments

1reaction

DubeySandeepcommented, Aug 14, 2019

@anmolshkl, This issue occurs sometimes and I don’t know how we can reproduce. I’ll add the full log if I’ll see this again!

0reactions

U8NWXDcommented, Dec 15, 2022

This no longer occurs. I made the following changes from commit 812fd09d38268036f8072de3e5fa365ba72f70e3:

diff --git a/core/templates/domain/blog/blog-dashboard-backend-api.service.spec.ts b/core/templates/domain/blog/blog-dashboard-backend-api.service.spec.ts
index e723669e28..6675e30809 100644
--- a/core/templates/domain/blog/blog-dashboard-backend-api.service.spec.ts
+++ b/core/templates/domain/blog/blog-dashboard-backend-api.service.spec.ts
@@ -28,7 +28,7 @@ import {
 import { BlogDashboardPageConstants } from 'pages/blog-dashboard-page/blog-dashboard-page.constants';
 import { BlogPostSummary, BlogPostSummaryBackendDict } from 'domain/blog/blog-post-summary.model';
 
-describe('Blog Dashboard backend api service', () => {
+fdescribe('Blog Dashboard backend api service', () => {
   let bdbas: BlogDashboardBackendApiService;
   let httpTestingController: HttpTestingController;
   let successHandler: jasmine.Spy<jasmine.Func>;

Then I ran the linter:

$ python -m scripts.linters.pre_commit_linter
...
18:45:53 FINISHED Third Party Js Ts Lint Checks Manager: 3.5 secs
----------------------------------------
Please fix the errors below:
----------------------------------------

/Users/cs/Documents/School/Stanford/ExtraCurriculars/oppia/code/oppia/oppia/core/templates/domain/blog/blog-dashboard-backend-api.service.spec.ts
  31:1    Please use "describe" instead of "fdescribe"  oppia/no-test-blockers

✖ 1 problem (1 error, 0 warnings)



---------------------------
Linter Checks Failed.
---------------------------

The error only appeared once.