question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make communication between progress-nav and interactions more transparent and maintainable

See original GitHub issue

The new progress-nav (#4265,#4365) has a Submit button which is supposed to act as the Submit button for the card’s interaction if show_nav_submit_button=True (some interactions, such as MultipleChoiceInput, don’t need a Submit button so that flag is False).

  1. Every interaction that uses the Submit button needs to have a callback attached for EVENT_PROGRESS_NAV_SUBMITTED, which is broadcast from the progress-nav when the user clicks on the Submit button (the interaction then performs its submitAnswer action). This is repetitive, we want that the interaction creator doesn’t have to manually define the callback for each interaction. This is also unnecessary because submitAnswer is originally defined on ConversationSkinDirective, so the progress nav should not need to go through the interaction directive to call it.
  2. Similarly, every interaction needs to call setAnswerValidity whenever the answer changes in order to control whether or not the submit button is enabled or disabled.
  3. The ItemSelectionInput is a special case that has show_nav_submit_button=False, but if there are >1 answer selections then the progress-nav still needs to show the Submit button. We want to remove this special case.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:24 (24 by maintainers)

github_iconTop GitHub Comments

1reaction
seanlipcommented, Apr 20, 2018

Noted, thanks @bansalnitish!

@AllanYangZhou – would you mind taking a look at this?

1reaction
vibhor98commented, Mar 14, 2018

No problem @bansalnitish

Read more comments on GitHub >

github_iconTop Results From Across the Web

Transparent Communication - Toward a Respectful Workplace
Transparent communication is the act of both good and bad information being shared upward, downward, and laterally in a way that allows all...
Read more >
Transparent communication: why and how to embrace it at work
Transparent communication builds mutual trust — by being open and forthcoming, we evoke a sense of trust, which further helps establish deep and ......
Read more >
COMMUNICATING WITH TRANSPARENCY AND INTEGRITY
In this module, you will examine how communicating with transparency and integrity is an impetus for creating more trust within your team, and...
Read more >
Open and Transparent Communication - SHRM
Fostering a culture of innovation requires open, transparent communication. Information must be shared upward, downward, and laterally.
Read more >
9 Ways to Build Transparent and Honest Communication In ...
Learn how transparent communication can improve your team's results, and read examples of how it looks in the workplace.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found