Remove GLOBALS from base.html

Explanation

We use GLOBALS for transferring dynamic variables between backend and frontend. Since we plan to move to static serving for our pages we need to get rid of GLOBALS.

GLOBALS consist of two types of variables: constants and dynamic variables. We should first get rid of the constants, there are three cases regarding constants:

• the constant is used both in frontend and backend
  • we should move it from GLOBALS to /assets/constants.js or keep the constant in feconf.py and make an AJAX request to retrieve the constant to the frontend.
• the constant is used just in the backend
  • we need to remove it from GLOBALS
• the constant is used just in the frontend
  • we should move it from GLOBALS to core/templates/dev/head/app.js as oppia.constant()

The variables in GLOBALS can be handled in many different ways. For reference: #5191 #5290 #5397 #5618

If you’d like to help with this issue, please select a file from the list below, put your name in parentheses next to it, and submit a PR after getting rid of the variable from GLOBALS in that file. Once the PR is submitted, you can tick the checkboxes.

Remaining GLOBALS

• ADDITIONAL_ANGULAR_MODULES (it’s used in interactions) @Jamesjay4199
• csrf_token
• status_code
• GCS_RESOURCE_BUCKET_NAME (app identity) @Jamesjay4199
• iframed @Jamesjay4199
• isTopicManager
• userIsLoggedIn @vrajesh978
  • check for the presence of App Engine authentification cookies
• login/logout
  • loginUrl
  • logoutUrl @abhaygupta97 (removed from codebase)
• SITE_FEEDBACK_FORM_URL @Jamesjay4199
• promo bar @abhaygupta97
  • PROMO_BAR_IS_ENABLED
  • PROMO_BAR_MESSAGE
  • Create backend handler for promobar message. Retrieve promobar message on frontend by AJAX. Move feconf.ENABLE_PROMO_BAR to constants.
• allowYamlFileUpload (deprecated – remove and move the functionality to admin Activities tab)
• NAV_MODE
  • Used for side navigation bar, can be removed and handled in frontend.
• user related @vojtechjelinek
  • isAdmin
  • isModerator
  • isSuperAdmin
  • can_create_collections
  • username
  • preferredSiteLanguageCode

[mighty-phoenix]

Thanks a lot! @YashJipkate

[abhaygupta97]

Hi @Jamesjay4199, iframed has been assigned to you. Go ahead! Thanks.