Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

dodgy tag suggestions

See original GitHub issue

I’ve been getting some dodgy suggestions recently…

two of these issues could be fixed by keeping post_office/post_depot and fuel/car_wash in sync, but the other two examples are just incorrect.

link	link
link	link

Issue Analytics

State:
Created a year ago
Comments:11 (7 by maintainers)

Top GitHub Comments

2reactions

bhouselcommented, May 3, 2022

Ok, I think what triggered this bug is the introduction of the operators/building/warehouse.json file on Apr 3: https://github.com/osmlab/name-suggestion-index/commit/b38623ebaab06cc77ebf70163d9ef915d267b9cd which would have entered the released NSI data files around v6.0.20220411

This code in iD/RapiD is the cause of this issue: https://github.com/facebookincubator/RapiD/blob/02d266bd7a6d4cf732b2e55d7b7e69ef3159d636/modules/services/nsi.js#L180-L187

By adding a category for building=warehouse that is kind of like saying that “buildings can be POIs” (in the same way that shops or amenities are)…

So previously - NSI would only match certain boring buildings under special conditions (if the feature in iD matched a building preset like building=yes and had no other interesting tags) Now - this code has started considering the building= tag “interesting” in a way that it didn’t before.

So for today, I’m just going to remove the building/warehouse file (sorry @k-yle) and I’ll think about ways that we can evolve NSI in in a way that it doesn’t produce surprises like this.

2reactions

1ec5commented, May 2, 2022

Not sure if it’s a reliable indicator, but the not:brand:wikidata usage rate increased markedly starting on April 11, which corresponds to this tag (compare to the April 4 tag).