`npm run build` will destroy correct data and add English name to Japanese name

After #6787 's merge I use npm run build command to auto format the data, but I noticed the Japanese name isn’t I just merged.

I manually checked and ensure them, then I run npm run build in a clear and up-to-date environment, here is a video:

https://user-images.githubusercontent.com/42690037/179353635-0449b0b1-9d07-4490-8119-776dedb427d0.mp4

(Sorry, old video mistake cut key point, so this is the full screenrecord)

If video can’t been play:

This may destroy any Japanese name in current data, but I don’t know how to do with it.

I run command on this commit: https://github.com/osmlab/name-suggestion-index/commit/b9a71323af8a3fa157a7b0fceb1d347a7b131f22

@bhousel

[bhousel]

Ok I think code I added in 03b393459 should mean that npm run build should not overwrite the local tags anymore… I’m definitely ok with using the bilingual main name and brand tags if this is what the local communities prefer. 👍

[bhousel]

What I’m confused is that why current npm run build only add "Sukiya" to "name:ja":"すき家", but don’t add "McDonald" to "name:zh":"麥當勞"

I think it is this code from the build script: https://github.com/osmlab/name-suggestion-index/blob/6e93a1c62edb33aea1b378e466711c87f327b4ed/scripts/build_index.js#L501-L503

The intent was to try to set default values for the language and locationset, but I agree that this rule is being too aggressive and it shouldn’t overwrite tags, so I’ll change it…