Store more information (including name handling rules) for each category
See original GitHub issueMoving this discussion to a new issue from the Greene King PR:
“What to do with names” is really the final unresolved thing about NSI that I need to figure out before making a real v5 release - you can see on https://github.com/openstreetmap/iD/pull/8305 that we’re running into this same thing with Amazon Lockers (they all have unique names), and on https://github.com/openstreetmap/id-tagging-schema/issues/119 the same thing with cinema chains.
I see three ways to handle a name
tag, depending on what kind of a feature we have:
- “strict name” - NSI provides the correct name, and iD should enforce it (e.g. “Burger King”)
- “default name” - NSI provides a name that works as a suitable default, but users can change it: (e.g. “Amazon Locker” / “Amazon Locker - Hemlock”) - I think pubs are like this
- “no name” - NSI doesn’t contain a name tag and takes no opinion on what the user wants to do - bus routes are like this.
I think this information should live in NSI somewhere, so we can remove the iD preset-field hack. I also think that this should be a per-category decision (maybe items can override it), but this is tricky because NSI has quite a lot of categories.
So I’ll be adjusting the file formats a bit to settle on a nicer way to capture more information for each category.
_Originally posted by @bhousel in https://github.com/osmlab/name-suggestion-index/issues/4902#issuecomment-779351342_
Issue Analytics
- State:
- Created 3 years ago
- Comments:15 (10 by maintainers)
All good suggestions! I’d add
amenity=cinema
to that list too… https://github.com/openstreetmap/id-tagging-schema/issues/119I’m going to try to make it per-category, but allow override per-brand.
I would consider actually that “Strict name” would be pretty rare. Even the full name of the McDonald’s on the corner of my street is “McDonald’s Lyon Bellecour”. IMHO : we should suggest the base name but allow the user to modify it so he can enter the full name.