question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Store more information (including name handling rules) for each category

See original GitHub issue

Moving this discussion to a new issue from the Greene King PR:

“What to do with names” is really the final unresolved thing about NSI that I need to figure out before making a real v5 release - you can see on https://github.com/openstreetmap/iD/pull/8305 that we’re running into this same thing with Amazon Lockers (they all have unique names), and on https://github.com/openstreetmap/id-tagging-schema/issues/119 the same thing with cinema chains.

I see three ways to handle a name tag, depending on what kind of a feature we have:

  • “strict name” - NSI provides the correct name, and iD should enforce it (e.g. “Burger King”)
  • “default name” - NSI provides a name that works as a suitable default, but users can change it: (e.g. “Amazon Locker” / “Amazon Locker - Hemlock”) - I think pubs are like this
  • “no name” - NSI doesn’t contain a name tag and takes no opinion on what the user wants to do - bus routes are like this.

I think this information should live in NSI somewhere, so we can remove the iD preset-field hack. I also think that this should be a per-category decision (maybe items can override it), but this is tricky because NSI has quite a lot of categories.

So I’ll be adjusting the file formats a bit to settle on a nicer way to capture more information for each category.

_Originally posted by @bhousel in https://github.com/osmlab/name-suggestion-index/issues/4902#issuecomment-779351342_

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:15 (10 by maintainers)

github_iconTop GitHub Comments

2reactions
bhouselcommented, Feb 16, 2021

Some more potential candidates for “default names” based on my experience:

All good suggestions! I’d add amenity=cinema to that list too… https://github.com/openstreetmap/id-tagging-schema/issues/119

Is it enough to define a category based only on the feature tag or do we need to categorize individual brands/features?

I’m going to try to make it per-category, but allow override per-brand.

1reaction
nuxpercommented, Feb 18, 2021

I would consider actually that “Strict name” would be pretty rare. Even the full name of the McDonald’s on the corner of my street is “McDonald’s Lyon Bellecour”. IMHO : we should suggest the base name but allow the user to modify it so he can enter the full name.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Product Categorization: A Guide to Organizing Your Products
Rather than stopping at your categories names, look to all your naming conventions. Categories, subcategories, category and product pages, ...
Read more >
Materials Handling and Storage
(OSHA 3077), for additional information. Employees should use blocking materials to manage loads safely. Workers should also be cautious when placing blocks.
Read more >
Database design basics - Microsoft Support
Decide what information you want to store in each table. Each item becomes a field, and is displayed as a column in the...
Read more >
Using CSV files to import and export products
To learn more about how to use CSV files, refer to Open and edit a CSV file. ... This is the same store...
Read more >
Add or remove inbox categories & tabs in Gmail - Android
Sort your emails into different inbox tabs, like Social or Promotions. When you open Gmail, you won't have to see all emails at...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found