question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

STYLE, TYP frame-or-series-union check no longer relevant

See original GitHub issue

This check is no longer relevant:

https://github.com/pandas-dev/pandas/blob/9ab55b4aed9018b070c939ffbdf232f99bf50f1a/.pre-commit-config.yaml#L83-L88

Since using PEP604 rewrites, this would be written as

x: Series | DataFrame

anyway.

x: FrameOrSeriesUnion

is actually just as long as the above, and arguably less explicit.


@simonjayhawkins thoughts on replacing all the FrameOrSeriesUnion occurrences, removing the alias, and removing the above check?

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:1
  • Comments:12 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
MarcoGorellicommented, May 24, 2021

Can I take it?

If the author of #41546 doesn’t update in, say, another week, then yeah, sure - let’s leave them a couple weeks to get back to us at least

0reactions
Anupam-USPcommented, May 24, 2021

Can I take it?

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to resolve AttributeError: 'DataFrame' object has no attribute
Year , I get the 1st Column and the second one displayed. However when I type data.Number , everytime it gives me this...
Read more >
Contributing to the code base — pandas 1.5.2 documentation
If a test can be shared between DataFrame/Series using the frame_or_series fixture, by convention it goes in the tests.frame file. Is your test...
Read more >
The “outdated sources” myth - APA Style
The “outdated sources” myth is that sources must have been published recently, such as the last 5 to 10 years. There is no...
Read more >
Frequently Asked Questions about Check 21
The law does not require banks to accept checks in electronic form nor does it ... How will Check 21 make check processing...
Read more >
Grammar and style guide for publishing in our journals - AGU
AGU follows American Psychological Association (APA) style on grammar, punctuation, ... Include book series and volume number when applicable.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found