STYLE "wrongplaced whitespace" rule doesn't error on its example of a bad string

The docstring reads

https://github.com/pandas-dev/pandas/blob/9ab55b4aed9018b070c939ffbdf232f99bf50f1a/scripts/validate_unwanted_patterns.py#L355-L361

yet this file doesn’t error if the script is run on it:

$ cat t.py 
rule = (
   "We want the space at the begging of "
   "the line if the previous line is ending with a \n "
   "not at the end, like always"
)
$ python scripts/validate_unwanted_patterns.py -vt 'strings_with_wrong_placed_whitespace' t.py 

Some other files which don’t error, though I can’t understand why:

$ cat t.py 
rule = (
   "  We want the space at the begging of"
   " the line if the previous line is ending with a \n "
   "not at the end, like always"
)
$ python scripts/validate_unwanted_patterns.py -vt 'strings_with_wrong_placed_whitespace' t.py 

$ cat t.py 
rule = (
   "We want the space at the begging of"
   " the line if the previous line is ending with a  "
   "not at the end, like always"
)
$ python scripts/validate_unwanted_patterns.py -vt 'strings_with_wrong_placed_whitespace' t.py

Hi @ShaharNaveh @datapythonista - do you have any context you could provide on the trailing newline rule? I’m struggling to make sense of it - thanks 😃

[datapythonista]

Seems to me that these two last elif should be just one checking the end of the first line, and the start of the second. Doesn’t make much sense this way.

But in any case, that was added for some case that wasn’t working with the simple validation of if the space is not at the end of the first line instead of at the beginning of the second, then fail. So, if there is nothing in our code now that fails with that simple condition, agree that better to remove.

[ShaharNaveh]

Seems to me that these two last elif should be just one checking the end of the first line, and the start of the second. Doesn’t make much sense this way.

IIRC the reason for those two elif was to be as explicit as possible, in order to cover as much cases as possible I guess it slipped from me that they are not really useful 😅

But in any case, that was added for some case that wasn’t working with the simple validation of if the space is not at the end of the first line instead of at the beginning of the second, then fail. So, if there is nothing in our code now that fails with that simple condition, agree that better to remove.

IIRC they did catch something in the codebase back then, but that was a year ago, I’m not really sure. Any way, I think it would be better to remove them, as long as they don’t seems to be needed. You can always add them again whenever you want.