Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Dependency version check fails even if required is "*"

See original GitHub issue

Hi!

During the development, I don’t have a version set, and every plugin has “unspecified” as a version. Since I do not define any contains on the version, I would expect that it will pass and won’t even try to parse the provided version.

However, it seems that the parsing kicks in too early: https://github.com/pf4j/pf4j/blob/f1dcdf8920f96f5dbb8515aeec402e9d3d7562c4/pf4j/src/main/java/org/pf4j/DefaultVersionManager.java#L42

My suggestion would be to add a check if the constraint is * and always return true.

Issue Analytics

State:
Created 4 years ago
Reactions:1
Comments:6 (4 by maintainers)

Top GitHub Comments

1reaction

decebalscommented, Feb 13, 2020

@bsideup

I will take a look. Until then you can supply your VersionManager custom implementation to the plugin manager via factory method DefaultPluginManager.createVersionManager. Your custom version manager implementation is very simple, just extends DefaultPluginManager.checkVersionConstraint (put your if test in front of default implementation).

0reactions

decebalscommented, Jan 22, 2022

Closed with #451.