DependencyResolver lost dependent info after plugin stop

Have two plugins A and B, B depends on A.

Step to reproduce:

1. Resolve and start A/B
2. Stop A, A/B will be both STOPPED, which is expected.
3. Start A.
4. Start B,
5. Stop A again, A is STOPPED but B remains STARTED, which expected to be both STOPPED.

Possible cause

in AbstractPluginManager.stopPlugin(plugin, stopDependents) methods, the following line

String dependent = dependents.remove(0);

also change the dependencyResolver, the dependent info is dropped with plugin stopping, unless we resolve everything again.

a reproducible repo should be found here. The pf4j version it’s using is v3.1.0, and same behavior under v3.4.1

[decebals]

The fix is available in version 3.6.0 (released today).

[j-barata]

Hi @hank-cp and @decebals Thank you both for your involvement in this issue resolution. As for me, this issue is resolved (I tested it with locally built pf4j and sbp for the moment, but the plugins activation/deactivation is ok now)