BlockingChannel.queue_declare hanging on non-string queue parameters

Under Python 3.6.4 and Pika 0.11.2, the BlockingChannel.queue_declare method hangs when setting its queue parameter to a value that is not of str type (e.g., int, bool, list, dict, tuple, NoneType).

Input:

$ python3 <<EOF
import pika
with pika.BlockingConnection() as connection:
    channel = connection.channel()
    channel.queue_declare(queue=[1, 2, 3])
EOF

[vitaly-krugl]

@lukebakken: Okay, so this now makes sense - the finally: block in the original BlockingConnection example and pika.BlockingConnection() as context manager in this new example will deadlock (trying to auto-close the channel) on the erroneously blocked channel that resulted from the assertion error and prevent the exception from bubbling up.

[vitaly-krugl]

And although the asynchronous connection example doesn’t hang since it simply doesn’t do anything that interferes with the processing of that exception, the channel state would still be messed up - in particular, I expectself._blocking to remain set and the redundant callbacks to continue to be registered.