question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove adapters/twisted_connection.py due to lack of test coverage. (pika v1.0.0 release target)

See original GitHub issue

The twisted_connection module was added in 2011, but to this date still has no meaningful test coverage. It’s unmaintainable without comprehensive test coverage and therefore pika cannot release v1.0.0 with twisted_connection in it.

We literally don’t know whether it works at all at this point and which API methods are working/broken.

I am hoping that this issue will inspire someone with interest in the twisted adapters to add comprehensive test coverage shortly. Barring that, twisted_connection must be removed from the package.

See the following for examples of pika acceptance test suites:

See also issues #615 and #616.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:10 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
glyphcommented, Aug 28, 2018

Thanks so much to @abompard for keeping the Twisted dream alive! 🎉

0reactions
wulczercommented, Sep 5, 2018

Thank you indeed @abompard - and apologies for not keeping up with the maintenance of the adapter. Three cheers for the Twisted community!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Test coverage visualization - GitLab Docs
How test coverage visualization works. Collecting the coverage information is done via GitLab CI/CD's artifacts reports feature. You can specify one or more ......
Read more >
Test Coverage in Software Testing (Tips to Maximize Testing ...
Test coverage helps monitor the quality of testing, and assists testers to create tests that cover areas that are missing or not validated. ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found