Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[ACTION] Refactor Filter Action

See original GitHub issue

We’ve gotten consistent feedback from users that the Filter actions are confusing to use. I think they’re probably overly complex, and can likely be simplified by flattening the “condition” configurations we currently present and updating some of the names, descriptions, etc.

Here is a non-working prototype of what I have in mind: https://pipedream.com/new?h=tch_wlXfNP

Notes:

The only reason the condition prop is set to have the default it does, is because I want to remove the secondValue prop in the case of the singleValueConditions (binary conditions), but we don’t support that logic in additionalProps() today.
Open to feedback or other suggestions on how to improve the usability

Issue Analytics

State:
Created a year ago
Comments:7

Top GitHub Comments

1reaction

dannyrooseveltcommented, Oct 28, 2022

LGTM, will wait for @vunguyenhung to give it another pass!

1reaction

dannyrooseveltcommented, Oct 28, 2022

@andrewjschuang thanks for making those changes! FYI I made a few slight tweaks and pushed to your branch.

I think the only thing that’s missing is the case sensitive prop – can you add that as an additionalProp for the text conditions, like in the current filter actions?

Top Results From Across the Web

Filter Actions - Tableau Help

Typically, a filter action sends information from a selected mark to another sheet showing related information. Behind the scenes, filter actions send data ......

Chapter 13. The MVC filter pipeline - ASP.NET Core in Action

This chapter covers. The MVC filter pipeline and how it differs from middleware; Creating custom filters to refactor complex action methods; Using authorization ......

[Solved]-How to refactor simple filter action in Rails?

How to refactor simple filter action in Rails? In rails how to take only the show action to a different path? Rails -...

Actions · nvim-treesitter/nvim-treesitter-refactor - GitHub

Filter by actor ; Add an option to apply the current scope highlight to the whole line · #49: Pull request #31 synchronize...

Refactoring Reducers Example | Redux

Structuring Reducers > Refactoring Reducers: Examples of ways to ... return updateObject(state, { visibilityFilter: action.filter })