Interface vs Struct

Thanks for this great library and your hardwork to make it great.

From https://pkg.go.dev/github.com/mxschmitt/playwright-go#pkg-index, the methods show out if the type is struct(like Playwright):

type Playwright
    func Run(options ...*RunOptions) (*Playwright, error)
    func (c *Playwright) Dispose()
    func (p *Playwright) Stop() error

But No method shows out if the type is defined as interface(like Page), we need to go to the type definition to find the available methods.

type Page

Is it possible to define the Page as struct?

type Page struct {
    // non export fields
}

func (*Page) Click(selector string, options ...PageClickOptions) error
func (*Page) Fill(selector, text string, options ...FrameFillOptions) error
... ...

What do you think about it? Thanks.

[ysmood]

@mxschmitt @AngangGuo I think use struct is better for both user and maintainer.

I can easily generate them and add documentation - as I do right now

Actually, you can also generate code for structs, I don’t understand why only the interface can do that.

I can ensure that I implement all upstream functions - the compiler ensures it

You can check this during the CI test process, pretty easy to use reflect to list all the methods of a struct. In this way, you can add more checks other than just check if a method is implemented, such as ensure unit test coverage, comments correctness.

I suggest checking the code design of Rod, it may help. Comparison with playwright: https://go-rod.github.io/#/why-rod?id=puppeteer

[AngangGuo]

Thanks, maybe add detailed documents in the website later on.