Missing types for page error events.

Hi, I can’t see the type definition of the page errors. For example:

page, _ := browserContext.NewPage()
page.Once("pageerror", func(err ???) {
	c.Logger().Errorf("an error on the page was detected: %s", err)
})

I also recommend using custom function types e.g

type RequestFailedEventHandler = func(request *Request)

[mxschmitt]

Cool, thanks for confirming. Some events like that or others are missing, try to come up with them over the next week.

Yeah I didn’t do much Go for a while and thought its fine to solve it like that. I wanted to keep the API pretty much the same as we have upstream so it corresponds with Python, Java or C#. If you have concrete improvements, I would be happy if you want to collaborate with me on the codebase, waitForEvent/newExpectWrapper is definitely something which is improvable. 👍

[StarpTech]

This issue was only about page error events. Your example would fix it. 👍

In general, I think the driver overuse reflection and empty interface. In many cases, we could develop against concrete types.

• https://github.com/mxschmitt/playwright-go/blob/5b4ed0ebc859c8c86596e9b0760d6ae3946c136d/helpers.go#L301-L326
• https://github.com/mxschmitt/playwright-go/blob/5b4ed0ebc859c8c86596e9b0760d6ae3946c136d/expect_wrapper.go#L7-L23

I like this approach https://mionskowski.pl/generic-event-dispatcher-in-go to handle events from different types.