osu! is registered to open all file types on Android

Describe the bug:

After installing the latest update, when opening most file types, osu! is presenting itself as an application that can open that file type. Notable examples are PDFs, APKs, etc.

Looking at osu!'s androidmanifest.xml, osu! is registered to open all mime types matching application/*

<intent-filter>
    <action android:name="android.intent.action.VIEW"/>
    <action android:name="android.intent.action.SEND"/>
    <category android:name="android.intent.category.DEFAULT"/>
    <data android:mimeType="application/*"/>
    <data android:pathPattern=".*.osz"/>
    <data android:pathPattern=".*.osk"/>
</intent-filter>

This suggests to use .*\\.osz and to specify android:scheme and android:host

I believe that if you don’t use backslashes, a file named fileosz would get matched in addition to file.osz. Some comments suggest using four backslashes, so test those two filenames with the modified androidmanifest.xml

osu!lazer version: 2020.1225.0

Device information:

Realme 6, Android 10 LG G Pad 8.3, Android 7.1.2

Logs:

Not needed as the issue is outside of osu!

[Game4all]

Note that the game only handles content uris for the moment so that should only make two intent filters to commit. Also I think that the send intent should be moved to its own intent filter as the only thing used to match for those are the accepted mime types.

[Susko3]

Finally figured it out, string arrays are the devil. Using more than one android:pathPattern or android:scheme will break it.

So the new IntentFilters should be:

[IntentFilter(
        new[] { Intent.ActionDefault, Intent.ActionSend },
        Categories = new[] { Intent.CategoryDefault },
        DataScheme = "content",
        DataHost = "*",
        DataPathPattern = ".*\\\\.osz",
        DataMimeType = "*/*"
        )]

Four in total for two filetypes (osz and osk) and two schemes (file and content)

I feel like using mime type */* is best, in case a file manager app misidentifies the file.

I’ll make a PR in a bit. First time using this PR stuff on GitHub, so it’ll take me a bit of time.