Seeking in a replay causes a miss on a 0 miss score
See original GitHub issueDescribe the bug: Watching a replay of a score I set on osu!lazer, there will always be a miss on the same slider, if you seek through the replay.
The score was set on this beatmap: https://osu.ppy.sh/beatmapsets/471285#osu/1007403
And this is the exported replay file (in zip format for github upload): Sinamer playing Lindsey Stirling - Master of Tides (LunaSaika) [Violin Dance].zip
Screenshots or videos showing encountered issue:
osu!lazer version: 2021.602.0
Logs: runtime.log performance.log
Issue Analytics
- State:
- Created 2 years ago
- Reactions:1
- Comments:10 (1 by maintainers)
Top Results From Across the Web
[resolved] Score screen shows 0 misses, but a ... - Osu! - ppy
Replays are not 100% precise, so the replay is most likely wrong, and it's showing a miss that doesn't actually exist. The score...
Read more >Coronary Calcium Score (Coronary Artery Calcification)
They can potentially miss many “preventable” cases of heart attack. ... the calcium score results is not as simple as looking at a...
Read more >How do football (soccer) referees feel when they see a ...
Sometimes, the pace and competitiveness of a game outstrip a Referee's knowledge and training, and experience, and a Referee misses a call.
Read more >Football Coach's Show replay: Temple
Score, Vanderbilt 40, University of Mississippi 0. Attendance 500. Vanderbilt finished that season 7-1. Mississippi was 6-1, with its only loss to the ......
Read more >By First Baptist Church Blue Springs ...
Missed this past Sunday? Join us for a replay of our worship service, and chat with our live host right now. We can't...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
So, the miss is in a slider head. Without the classic mod, the slider head position is moved to follow the slider ball: https://github.com/ppy/osu/blob/0dcdad98397453b439cab67421e29ecb3ca13f00/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSliderHead.cs#L81
A hit circle uses the
IsHovered
property to check the hit when a button is pressed:https://github.com/ppy/osu/blob/b82190e157deb303bf15ba69b56fb5a55ae4584d/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableHitCircle.cs#L229
The issue is this
IsHovered
is only updated inInputManager
’s update, using thePosition
from the previous frame. The issue occurs on fast forward due to the different frame rate. In theory, the same issue can happen by using different fps limiter settings. Related (?): #4288.I’m pretty sure this isn’t a new issue and has been around for a while, but I can’t actually find an open issue tracking this.