question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improve auth error

See original GitHub issue

If we try to use html tags as user authorization data (email: <script>alert(document.cookie)</script>@gmail.com and/or password: <script>alert(document.cookie)</script>), we get an error: https://imgur.com/gL8iE34

I understand that it is associated with another library, but it has not been updated for more than 2 years and I think the author is no longer developing it. Can you fix this problem at your library level?

Issue Analytics

  • State:open
  • Created 4 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

2reactions
wvfflecommented, Nov 3, 2019

In my opinion we should throw something like Authentication server error. JSON error doesn’t say anything useful for a regular user and may be hard to understand.

Edit: No matter if it’s a mojang ban or any other type of error.

We can also fork yggdrasil and add support for those errors. Maybe mojang sends different HTTP codes for ban and input error? This would allow us to handle more errors and be more helpful for a regular user.

0reactions
MrZillaGoldcommented, Nov 3, 2019

With other tags, everything is fine. But still, why not handle this error on the library side and output it to .on(“error”)?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Optimizing authorization rates: How to reduce network declines
This guide provides an introduction to managing authorization rates and helps you understand how to reduce the number of legitimate payments that fail....
Read more >
Error Handling Best Practices - Auth0
Error conditions returned from API calls must be handled and processed in an appropriate manner. Failure to do so can lead to unhandled...
Read more >
How to boost your authorization rate with confidence
From machine learning to tokenization, merchants are now using a range of methods to safely improve authorization rates.
Read more >
Avoiding Chargebacks from Transaction Authorization Errors
Authorization errors occur when merchants make a misstep or don't follow best practices when attempting to gain authorization for a credit card transaction....
Read more >
Improved error handling in the auth component (#237) · Issues
Improved error handling in the auth component ... It is bad practice to show the traceback in prod, so there may be something...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found