Merge mineflayer-blockfinder into mineflayer

Is your feature request related to a problem? Please describe.

bot.findBlocks is one of the most commonly used functions. Current implementation is slow and shouldn’t be used.

Describe the solution you’d like

I’d rather make minefalyer-blockfinder a part of mineflayer. It’s one of the most used plugins so I’d consider merging it.

Describe alternatives you’ve considered

Alternatively we can remove bot.findBlocks from mineflayer if it’s too high level function

Additional context

None 😉

[wvffle]

Do we have contact with the maintaimer of the blockfinder, @Darthfett? We could move this repo into the organization. It’ll be easier to maintain

[rom1504]

I agree with the fact we need to solve that issue

I think we should not merge it but add it as a dependency (in package.json) somewhere : either in mineflayer itself or a mineflayer example (with its own package.json), I’m not sure, it’s needed to estimate the code complexity of mineflayer-blockfinder

On Thu, May 16, 2019, 08:54 Kasper Seweryn [e-mail] wrote:

Is your feature request related to a problem? Please describe.

bot.findBlocks is one of the most commonly used functions. Current implementation is slow and shouldn’t be used. Describe the solution you’d like

I’d rather make minefalyer-blockfinder a part of mineflayer. It’s one of the most used plugins so I’d consider merging it. Describe alternatives you’ve considered

Alternatively we can remove bot.findBlocks from mineflayer if it’s too high level function Additional context

None 😉

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/mineflayer/issues/813?email_source=notifications&email_token=AAR437SMWOVQRO6UY3KRN2TPVUAJBA5CNFSM4HNJPLMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUC3TYQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAR437V4X32TNT7C5OXQYADPVUAJBANCNFSM4HNJPLMA .