Finding nearset players

I’m trying to make a bot that attacks nearby players. The problem is that the bot only tracks the first nearest player, and if the player leaves the server or teleports to another world, the bot simply remembers the last point of coordinates. How to make sure that if a player disconnects from the server, the bot selects a new closest player?

if (message == ".farm") {
  clearInterval(afk)
  var target = minecraft.nearestEntity(({
    type
  }) => type === 'player')
  minecraft.pathfinder.setMovements(defaultMove)
  minecraft.pathfinder.setGoal(new GoalFollow(target, 1), true)
  setInterval(() => {
    let distance
    if (target.position) {
      let distance = target.position.distanceTo(minecraft.entity.position)
    }
    if (distance < 3) {
      minecraft._client.write('arm_animation', {
        hand: 0
      });
      minecraft.setQuickBarSlot(1)
      minecraft.attack(target)
    }
  }, 200)
}

[TheDudeFromCI]

This is because you forgot to check the target in the event.

bot.on('entityGone', (entity) => {
  if (entity !== target) return // <======== This Line ==========
  attackNearestPlayer()
})

Without that line, the bot will select a new target any time any entity despawns, dies, teleports, gets unloaded, moves out of render distance, etc. Which is quite often.

Also, I recommend you move that target variable to a global scope so it can be read by both functions.

Lastly, don’t call bot.on inside a command, since this creates a new listener each time, but does not remove the existing ones. You’ll create a memory leak and also have the same code running multiple times in parallel which can cause unexpected bugs later on. It’s best to create that method right after creating the bot. With the if (entity !== target) return line, this means that if not target is assigned, it will never be called. If a target is assigned, it will only be called when that target specifically disappears.

[shketov]

This is because you forgot to check the target in the event.

bot.on('entityGone', (entity) => {
  if (entity !== target) return // <======== This Line ==========
  attackNearestPlayer()
})

Without that line, the bot will select a new target any time any entity despawns, dies, teleports, gets unloaded, moves out of render distance, etc. Which is quite often.

Also, I recommend you move that target variable to a global scope so it can be read by both functions.

Lastly, don’t call bot.on inside a command, since this creates a new listener each time, but does not remove the existing ones. You’ll create a memory leak and also have the same code running multiple times in parallel which can cause unexpected bugs later on. It’s best to create that method right after creating the bot. With the if (entity !== target) return line, this means that if not target is assigned, it will never be called. If a target is assigned, it will only be called when that target specifically disappears.

Oh, my bad. Thank you so much, everything is working as it should!