Is it ok to reuse Prism object when loading multiple languages?

Hey

I noticed that if I do:

loadLanguages(["javascript"]);

and then later loadLanguages(["markup", "javascript"]);

Then the second one won’t parse the javascript. However if ["markup", "javascript"] is loaded first it works correctly.

[mAAdhaTTah]

Wow, nice catch.

If we wanted to still avoid said second parameter, we’d have to resolve them in the loadLanguages function, e.g. when we do this:

loadLanguages(['markup', 'javascript']); loadLanguages('markup');

We’d have to reload javascript after we’ve loaded markup the second time.

Is that “optional dependency” made explicit anywhere? We could add optional dependencies to components.js, and reload them conditionally based on whether they’ve been loaded already or not.

It’s not ideal, from an implementation perspective, but I’d much rather pull that complexity into Prism rather than expecting users to understand whether or not they should be invalidating the cache. Understanding whether to do so requires users to understand Prism’s internals, which I’d like to avoid even at the expense of making loadLanguages more complex.

[mAAdhaTTah]

Basic idea is this:

delete require.cache[require.resolve(pathToLanguage)]

Would make a Good First Issue™.