Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Version 1.14.0 crashes when used in Spectacle

See original GitHub issue

Version 1.14.0 appears to have introduced a breaking change to spectacle, which I initially reported to them but probably really belongs here.

The prism portion of the stacktrace:

Uncaught TypeError: Cannot read property 'buildPlaceholders' of undefined
    at prism-handlebars.js:30
    at Object.run (prism-core.js:451)
    at highlight (prism-core.js:280)

Apparently introduced in this commit.

Please let me know if I can provide any more information. Many thanks for the time and effort.

Issue Analytics

State:
Created 5 years ago
Comments:13 (6 by maintainers)

Top GitHub Comments

2reactions

sslotskycommented, Apr 17, 2018

I am sorry if I’m being slow, I just really do not understand how this isn’t a breaking change. We upgrade a minor version of prism and suddenly our code doesn’t work anymore.

1reaction

Golmotecommented, Apr 17, 2018

Hi.

This seems like a breaking change for consumers of this library, should there have been a major version bump?

I’ve took the time to wonder about this since you posted this issue.

Prism provides no insurance that the dependencies between the components won’t change. It does provide the insurance that the files components.json (and components.js) will contain the required information regarding those dependencies.

Furthermore, we usually assume that users using Prism in the browser will get a bundle from the Download page. If they were to upgrade to 1.14 using the “redownload URL” on this page, there would be no problem. The ones who don’t can still use the Autoloader plugin if they don’t want to handle the dependencies themselves. Users using Prism with Node are encouraged to use the loadLanguages() helper function, introduced in 1.13, if they want the dependencies to be automatically handled.

For the rest of the users, the ones who decided, on their own, to manually handle those dependencies, yes 1.14 will break their code, regarding the ERB, Handlebars, PHP and Smarty components.

Taking all of this into account, I don’t consider 1.14 a BC-breaking release.

I’m really sorry this introduced an issue on Spectacle’s side, yet the way they handle the dependencies is not really realiable. I don’t know their use case, but they should probably have come to us (and maybe they still should) so we could discuss to find a better solution.