question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Feature request] Do not include stale label while getting stale issues

See original GitHub issue

Hi,

We’re discussing using stale bot in Node.js core repository in https://github.com/nodejs/node/issues/28798

While going through your code, I noticed that the function mark calls getStale for getting stale issues https://github.com/probot/stale/blob/e3c53ebf879cccaf856fba1602fdd67f878c3ee3/lib/stale.js#L42

The function getStale doesn’t exclude already stale issues https://github.com/probot/stale/blob/e3c53ebf879cccaf856fba1602fdd67f878c3ee3/lib/stale.js#L72-L73

The function markIssue marks stale issues as stale https://github.com/probot/stale/blob/e3c53ebf879cccaf856fba1602fdd67f878c3ee3/lib/stale.js#L115-L136

Feature Requests:

  1. Do not include staleLabel while searching for stale issues
  2. Do not add staleLabel if already present while commenting on stale issues
  3. Exclude comment activity from stale bot while unmarking updated issues https://github.com/probot/stale/blob/e3c53ebf879cccaf856fba1602fdd67f878c3ee3/index.js#L41-L43
  4. While searching for closableItems in sweep, instead of searching for days since last activity of more than daysUntilClose, search for staleLabel marked for more than daysUntilClose https://github.com/probot/stale/blob/e3c53ebf879cccaf856fba1602fdd67f878c3ee3/lib/stale.js#L49-L63
  5. Any other impact this change might have.

This will be helpful in projects where daysUntilClose > daysUntilStale The stale bot will continue commenting every daysUntilStale of activity, and close issues after daysUntilClose

Regards, Trivikram

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6

github_iconTop GitHub Comments

1reaction
issue-label-bot[bot]commented, Jul 29, 2019

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.78. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

0reactions
stale[bot]commented, Jan 28, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

Read more comments on GitHub >

github_iconTop Results From Across the Web

[Feature] Add label when stale issue gets a response #460
The problem When the issue is marked as stale AND the author responds, the issue will continue to be marked as stale and...
Read more >
Triage Operations - GitLab
Auto-labelling of issues and merge requests. Our triage bot will automatically infer section, stage, and group labels based on the category/feature already ...
Read more >
Stale bot - "pinned" label? - Development - beets
We now have months of the stale bot running. What do we gain from it? To me it creates a false sense of...
Read more >
@sonia-corporation/stale - npm
If an update occur after being stale, the stale label will be removed and the count will be reset back to 30 days....
Read more >
Best Practices for Using GitHub Issues - Rewind
If your repository is brand-new, you don't have a lot of issues ... don't forget to go through stale issues and close them...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found