Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Feature Request: Let Mergify merge ProjenUpgrade PRs once build passes

See original GitHub issue

ProjenUpgrade PRs now require manually merge and is a little bit annoying.

Would be great if we allow Mergify to merge it for us just like how it works with dependabot PRs.

more discussion here: https://twitter.com/pahudnet/status/1310870742746034176

Proposed Solution:

We probably can add a rule here: https://github.com/eladb/projen/blob/ccb0aa946d9be7c328676396b58c9cb0bba1aebb/src/node-project.ts#L632-L658

And I was wondering if we should provide an opt-out option and where would be the best place to hold this option.

Issue Analytics

State:
Created 3 years ago
Comments:8 (8 by maintainers)

Top GitHub Comments

1reaction

eladbcommented, Oct 1, 2020

Okay, we’ll go with auto-merge. On it.

0reactions

Chriscbrcommented, Dec 5, 2020

Closing as this appears to be resolved

Top Results From Across the Web

merge — Mergify documentation

The merge action merges the pull request into its base branch. Mergify always respects the branch protection settings. When the conditions match and...

queue — Mergify documentation

A simple usage of the queue is to merge pull requests serially, ensuring they all pass the CI one after the other. The...

Mergify

Faster & safer code merge. We save your time by automatizing your pull requests and securing the code merge using a merge queue....

Example Rules — Mergify documentation

Example Rules · ✓ Automatic Merge when CI works and approving reviews · Merging based on Modified Files · Less Strict Rules for...

Conditions — Mergify documentation

Attribute Name Value type Value description body‑raw string The contents of the pull request description. closed Boolean Whether the pull request is closed. closed‑at Timestamp or...