question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Feature request: Support custom licenses

See original GitHub issue

Problem

It seems that currently Projen supports following licenses:

  • Apache-2.0
  • MIT
  • MPL-2.0

… but for internally distributed (within a company) constructs / projects one should be able to set the license to something else (proprietary license).

Proposed solution

One idea could be allowing to specify the license as string:

project.license = `COWBOY LICENSE
This is a custom proprietary license. 
Only people wearing cowboy hats can use this project. 
Beware of our scary legal team.`;

Proposed Workaround

For a workaround one could use in .projenrc.js:

project.gitignore.exclude('LICENSE');

… but that doesn’t work since Projen applies !/LICENSE after that: Screenshot 2020-09-27 at 20 35 44

So at least having some way of “forcing” manual project.gitignore.exclude operations to be appended at the end would solve the issue.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:11 (11 by maintainers)

github_iconTop GitHub Comments

1reaction
Chriscbrcommented, Oct 7, 2020

Maybe there could also be an option to support no license, and have it automatically set private: "true" in the package.json to avoid unintentionally publishing a package. (Or this flag could be provided by a separate option)

0reactions
jmoureloscommented, Nov 11, 2020

Thanks a lot for the feedback!

Yeah I guess I wouldn’t mind using ‘NO_LICENSE’ to avoid confusion, but it’s fair that a flag works just as well. Or putting all related fields in a licenseOptions like you suggested. I don’t really have a strong opinion here.

I don’t have a strong opinion either, so I will just let it stay as it is currently. I set the PR to ready for review.

Any other missing placeholders substitutions should definitely be added! But whenever possible, these fields should be passed from the rest of the project options – not provided via license-specific options. This way the user only has to specify properties at the project level (such as the author name, year, etc.), and the fields will automatically propagate to all appropriate files, including the license.

Definitely, I was thinking of cases where the information would be specific for the license, but I can see that that is not very likely.

Read more comments on GitHub >

github_iconTop Results From Across the Web

12 powerful feature request software tools for SaaS - Savio
Not confident about your roadmap? Use these top tools to organize and prioritize software feature requests and build a product that sells.
Read more >
Feature Request - More Fields for Software Licenses #2411
The ability for the license records to hold attachments for licenses that require key files. The inclusion of custom fields for licenses (I...
Read more >
Gather Feature Requests & Requirements Using Your Own ...
Create customized web forms in just minutes for use in gathering requirements from customers as well as internal stakeholders such as Sales and...
Read more >
Support Custom Report - Katalon Community
Support Custom Report · Feedback & Reviews Feature Requests ... licenses, you can create a ticket via Zendesk for further support.
Read more >
Tracking Bugs and Feature Requests - GitLab
Ideally, we want to keep diligent track of the bugs and feature opportunities we encounter through tickets and internal support requests.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found