`get_qcs_objects_for_notebook` needs cleanup and bugfixes
See original GitHub issueDescription of the issue
get_qcs_objects_for_notebook
was added in #4286 and is super useful to abstract out the authentication logic for accessing QCS. However, I think there are a few rough edges – from a user perspective, I haven’t dug into the technical details yet.
- In the getting started with QCS tutorial, the object is used for authentication and verification that the authentication went through (
device_sampler.is_signed_in
) but after that, there’s no usage of thedevice_sampler
object. This doesn’t look like the intended usage of an object specifically has adevice
andsampler
objects ? - It looks like
sqrt_iswap
gateset string is hardcoded deep inside theget_qcs_objects_for_notebook
method. This also looks like a bug and something that shouldn’t be intended? https://github.com/quantumlib/Cirq/blob/6562a0521ffda79c8f140774ce292cace346301b/cirq-google/cirq_google/engine/qcs_notebook.py#L119
Cirq version 0.13.0
Issue Analytics
- State:
- Created 2 years ago
- Comments:10 (2 by maintainers)
Top Results From Across the Web
Wasm jiterpreter cleanup and bug fixes pt. 4 #79324 - GitHub
Wasm jiterpreter cleanup and bug fixes pt. 4 #79324. Draft. kg wants to merge 1 commit into dotnet:main. base: main. Choose a base...
Read more >When and why to clean up your code: now, later, never
Miscellaneous Cleanups of anything else, from coding standard violations to awkward idioms. ... You need to get a bug fix to users ASAP....
Read more >NEWS
CLEANUP : Removed some internal functions from the help index. Version 0.7.3 (2011-06-25). Miscellaneous. ROBUSTNESS: Updated package dependencies. Bug Fixes.
Read more >Clean Up Your Bug Tracker and Keep Numbers Manageable
A good team likely is trained to consistently report defects as accurately and promptly as possible. This means that over time the bug ......
Read more >LightBurn 0.9.19 patch release - A couple bug fixes, mostly ...
... 0.9.19 patch release - A couple bug fixes, mostly small cleanup. by LightBurn Software November 21, 2020. The first changes in this...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
I’m taking this on in #5759
I think we can address some of the shortcomings of
get_qcs_objects_for_notebook
in #5240. @verult, should I assign this issue to you?