Unable to reproduce the results of HER-TD3
See original GitHub issueWhen I first run the script with:
python -m examples.her.her_td3_gym_fetch_reach
It raised an error:
Traceback (most recent call last):
File "/home/fcloud/anaconda3/envs/rlkit/lib/python3.5/runpy.py", line 184, in _run_module_as_main
"__main__", mod_spec)
File "/home/fcloud/anaconda3/envs/rlkit/lib/python3.5/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/fcloud/workspace/rlkit/examples/her/her_td3_gym_fetch_reach.py", line 88, in <module>
experiment(variant)
File "/home/fcloud/workspace/rlkit/examples/her/her_td3_gym_fetch_reach.py", line 65, in experiment
**variant['algo_kwargs']
TypeError: __init__() missing 2 required keyword-only arguments: 'her_kwargs' and 'td3_kwargs'
So I modified the source code as follows:
her_kwargs = dict(observation_key='observation', desired_goal_key='desired_goal')
td3_kwargs = dict(env=env,
qf1=qf1,
qf2=qf2,
policy=policy,
exploration_policy=exploration_policy)
algorithm = HerTd3(
her_kwargs=her_kwargs,
td3_kwargs=td3_kwargs,
replay_buffer=replay_buffer,
**variant['algo_kwargs']
)
Then the experiment can be launched successfully, but the results seem not correct:
Issue Analytics
- State:
- Created 5 years ago
- Comments:6 (2 by maintainers)
Top Results From Across the Web
What should I do if I cannot reproduce experimental published ...
Try to replicate the experimental conditions as much as possible, try to get any "hidden" steps if there are any, and if the...
Read more >Why Can't I Reproduce Their Results? - Hacker News
If you run their code on their data you haven't reproduced their result. You have merely copied it. If their code works on...
Read more >The Trouble with Reproducing Results - Labtag Blog
Reproducing experimental results graph It's impossible to know which studies are trustworthy in the realm of science until others try to ...
Read more >What Happens When Someone Fails to Reproduce ... - Enago
If you receive notification that someone failed to reproduce your research, the situation may not be as bleak as you would think.
Read more >How to Reproduce a Non-Reproducible Defect and Make ...
Why reproducing a Defect is so important and how to reproduce a Non-Reproducible Defect - Here are some tips and ticks to make...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Split by
exp_name
orunique_id
.The comments at the top of the HER scripts are confusing (“This should results in an average return of ~3000 by the end of training.”). I think they aren’t meant for the environments in the script?