Dynamic URLs don't use `basePath` correctly

Are you reporting a bug?

Yes

The basePath (and stagingBasePath and devBasePath) works fine for the static URLs that are generated in .html files, but URLs that are dynamically created via JavaScript don’t use basePath correctly. Sometimes they leave it off altogether. Other times they repeat it twice.

Related (but different) issues:

• Issue #926
• Issue #972

Environment

1. react-static -V: 6.2.0
2. node -v: 10.11.0
3. npm -v: 6.4.1
4. Operating system: Windows 10
5. Browser and version (if relevant): Chrome 71

Steps to Reproduce the problem

1. Create a new project using the “basic” template

2. Add the following to the static.config.json

  basePath: "PRODUCTION",
  stagingBasePath: "STAGING",
  devBasePath: "DEV",

1. Run the dev server (npm start) and see that everything works correctly

• (although it’s served from / not /DEV see Issue #972)

1. Do a staging build (npm run stage)

2. Move the contents of the dist folder to dist/STAGING to match our site config

mv dist STAGING
mkdir dist
mv STAGING dist/STAGING

1. Remove the -s option from the serve script in package.json. That option causes problems due to the 404 issue that I’m demonstrating here.

2. Run the static server (npm run serve)

• The site is served from /STAGING and not from /. This is good because it accurately tests whether our site will work correctly in a non-root directory. 👍

1. Open your browser dev tools and look at the “Network” tab.

• Try to browse to a few different pages of the site. You’ll see a lot of 404 errors.

• All the URLs in the .html files are correctly prefixed with /STAGING and work correctly

• URLs that are loaded dynamically via JavaScript are mostly broken.

  • Some are missing the base path (e.g. /templates/src-pages-404.xxxxx.js)

  • Some have the base path twice (e.g. /STAGING/STAGING/about/routeinfo.json)

[DDunc]

@tannerlinsley, Please reopen when you get the chance, thanks!

We’re also experiencing this issue and seemingly-related basePath bugs with both React-Static 5.9.12 and 6.x. I’m a huge fan of React-Static, I’ve migrated projects from other SSR libraries and it’s been a great experience overall, but unfortunately this is a showstopping blocker. I really appreciate all the work you’ve done though, using React-Static has been like a breath of fresh air!

I’d like to help out as well and I’ll take the information above as a jumping off point for my own attempts to root cause this cluster of issues. In terms of branch(es) to work against, is master the preferred branch or could it also be worthwhile to look at v5 and v7?

[tannerlinsley]

Master is up to date for v6 so use that one! Thanks for your willingness to help!

On Thu, Feb 28, 2019 at 3:32 PM Duncan [e-mail] wrote:

@tannerlinsley https://github.com/tannerlinsley, Please reopen when you get the chance, thanks!

We’re also experiencing this issue and seemingly-related basePath bugs with both React-Static 5.9.12 and 6.x. I’m a huge fan of react-static, I’ve migrated projects from other SSR libraries and it’s been a great experience overall, but unfortunately this is a showstopping blocker. I really appreciate all the work you’ve done though, using React-Static has been like a breath of fresh air!

I’d like to help out as well and I’ll take the information above as a jumping off point for my own attempts to root cause this cluster of issues. In terms of branch(es) to work against, is master the preferred branch or could it also be worthwhile to look at v5 and v7?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/nozzle/react-static/issues/975#issuecomment-468465800, or mute the thread https://github.com/notifications/unsubscribe-auth/AFUmCddgi0lHxlDKkwLcWM0liqQeJB_Nks5vSFkGgaJpZM4aFEZi .