It's possible to produce a "successful" build that yields no JS bundle or HTML

Are you reporting a bug?

Yes. It’s possible to produce a “successful” build that yields no JS bundle or HTML. I stumbled across this issue when one of my data API end-point was unavailable.

Environment

1. react-static -V: 6.1.4
2. node -v: 8.9.0
3. npm -v: 5.5.1
4. Operating system: Mac OS
5. Browser and version (if relevant): N/A

Steps to Reproduce the problem

1. Run react-static create and select the basic template
2. Edit static.config to return an empty array from getRoutes
3. Delete src/pages
4. Run yarn build
5. Observe that, despite a console warning of no “index” page, build is successful, and that dist contains just react-static-browser-plugins.js
6. Edit static.confg and throw an error from getRoutes
7. Run yarn build
8. Observe that build is successful, and that dist contains just react-static-browser-plugins.js

Expected Behavior

Because there are no “page” routes or routes returned by getRoutes, yarn build should fail with exit code 1 in both cases. Previous in v5, when I threw an error caused by an unavailable end-point the build would fail. The current v6 behaviour can result in a CI tool such as Netlify deploying the minimal dist directory

[tannerlinsley]

v7 uses a whole new flow for CLI commands and should no longer swallow errors. If you still run into this error in the new version, please reopen this issue!

Thanks for your feedback on this as always.

[tannerlinsley]

After a passthrough of this logical tree and some debugging, I couldn’t find where the error’s are getting swallowed. I’m going to do another run-through later this week.