question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ReferenceLine generates warning about alwaysShow

See original GitHub issue

There is a bug when using a ReferenceLine or ReferenceDot or ReferenceArea in a chart.

When a one of the reference is used in a chart a warning saying “The alwaysShow property is deprecated” is displayed when the mouse hover the chart. Obviously the alwaysShow property is not set on the reference. It seems to be related with the modification of July 6th commit 51c55a6ea4c93034b756700bc350d5d538b22425, by @paulmelnikow. The warning should have been:

 warn(alwaysShow === undefined,
      'The alwaysShow prop is deprecated. Please use ifOverflow="extendDomain" instead.');

Where the condition is “===” instead of “!==” since the warn function condition is what you are expecting to avoid the warning and not what cause the warning to be displayed.

Obviously the workaround is to set the alwaysShow property to something different than undefined.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:9 (1 by maintainers)

github_iconTop GitHub Comments

4reactions
paulmelnikowcommented, Aug 2, 2018

Oops! Sorry about that. I’ll open a PR with a fix.

1reaction
DavidHenri008commented, Oct 4, 2018

Let’s close it.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Release notes - Gradle quality plugin
Add UnusedLocalVariable; Change MultipleStringLiterals to react on strings more than 2 chars only and allow 2 duplicates (to avoid warning in trivial cases)....
Read more >
43755 - Warning messages might be issued when using the ...
WARNING: REFERENCELINE statement must be overlaid with one or more non-parameterized plots in a PROTOTYPE layout. The plot will not be drawn. An ......
Read more >
How to set up charts with comparison of measures - totals vs ...
Hello everyone, I would like to visualize a comparison in a chart. In the left chart you can see my bank confirmations for...
Read more >
recharts/CHANGELOG.md - UNPKG
95, - Fix alwaysShow warn() condition in ReferenceLine. 96, - Fix Tooltip disappears when using setState() ... 185, - Use cloneElement to create...
Read more >
CHANGELOG - TaskJuggler API documentation
Priority inversions now generate a warning. * 'competitors' and 'competitorcount' ... Ensure that Clarity timesheets always show all projects in timesheets.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found