Exclude disabled features from "Find feature" steps

Description

I was using the awesome “Find Feature” button to figure out why in my list of PRs and issues some are grey.

It explained to me that the issue was coming form dim-bots, but when I checked, it was already disabled. Luckily I discovered dim-visited-conversations along the way since I only searched for dim, so I was abe to disable it.

But I wonder why the it even suggests features that are disabled…

I think it could also be considered a bug, but the form for that didn’t seem to fit.

Steps to reproduce:

1. Disable dim-bots and enable dim-visited-conversations
2. Open any list of PRs or issues where you can see some title being dimmed and others aren’t (the link I added works for me but might not work for you)
3. Open the options, scroll to the bottom and click “Find Feature”
4. go back to the tab from step 2 and refresh the page
5. click “yes” whenever some PR is dimmed and “no” if all PRs are black/white

Screenshot

No response

Example URL

https://github.com/xmldom/xmldom/issues

[cheap-glitch]

Just reproduced it again, this time with a recording.

Thank you for the recording! I think I understand where the issue is coming from: on the fourth step (with 6 steps remaining), you clicked “Yes” where it should have been “No”, because you saw the collapsed issue at the bottom of the page.

This is not caused by dim-visited-conversations, but dim-bots instead, which collapses and dims every PR, issue and commit made by a bot. And the “Find feature” mechanism only works properly if focusing on the effects of a single feature.

Your point is valid nonetheless, because the feature finder always starts with every feature enabled, regardless of the user’s settings. Since the user might be exposed to features they aren’t used to seeing, this can cause confusion and derail the process.

So I think we should make the finder work with only the features already enabled. Not only would it be more straightforward, it’d be faster too (less features to consider = less steps).

[cheap-glitch]

Thanks for the detailed report!

However I tried to reproduce it in the same conditions as mentioned, and I got the correct answer of dim-visited-conversations.

My guess is that you must have clicked the wrong button during one of the steps — probably because the color of the visited links isn’t very different from the regular one.