Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Feature request: ignore specific files in PR lines count

See original GitHub issue

Description

Add options/settings to ignore specific files (using pattern if possible) in the lines count in PRs.

Motivations

Changes in yarn.lock files, for example, can include thousands of lines, while actual code changes in the PR can be minimal.

screen shot 2018-07-02 at 11 01 35 am

It would be very useful to be able to remove that count from the PR summary, while still showing it somehow (maybe through a tooltip?).

Issue Analytics

State:
Created 5 years ago
Reactions:29
Comments:6 (3 by maintainers)

Top GitHub Comments

8reactions

jerrygreencommented, Jan 15, 2020

Sorry for necropost but this one sounds good actually. I randomly got here from google trying to find out if it’s possible. Though, I don’t see how is that possible with a browser extension. I think maybe it shouldn’t be even Github responsibility, maybe some git extension like git-lfs or just newer version of git.

I would even say it’s having this in .gitignore:

yarn.lock

And having this in something like .repositoryignore:

!yarn.lock

So it won’t be treated as code, but still will be pushed into repository… Well, wait! Just ended up with that git-lfs is actually enough for this purpose lol. So the change will be not the whole file of hundreds or even a thousands of rows, but will be just a single row, - a different hash of whole yarn.lock file. However, it may turn out to break things, because the files are formally not in the repository but inside an external storage.

1reaction

fregantecommented, Jun 10, 2020

This seems to be possible since the file filter does have this information per-file:

But it still doesn’t belong to Refined GitHub. If anyone is interested, please suggest it on https://github.com/sindresorhus/module-requests and mention it in:

https://github.com/sindresorhus/refined-github/pull/1085 (has the starting code) https://github.com/sindresorhus/refined-github/issues/1316 https://github.com/sindresorhus/refined-github/issues/1395 (current issue)

Top Results From Across the Web

Feature request: ignore specific files in PR lines count #1395

This feature would be to ignore count for specifically chosen files where changes don't need to be reviewed, and could be used as...

Ignoring specific files, file types or folders in a pull request diff

While you cannot exclude files from a Pull Request, you can (since Dec. 2018) filter them.

Exclude files from pull request diffs | Bitbucket Cloud

Exclude files from appearing in the diff view of a pull request in Bitbucket Cloud by specifying patterns in the 'Excluded files' repository...

gitignore Documentation - Git

A gitignore file specifies intentionally untracked files that Git should ignore. Files already tracked by Git are not affected; see the NOTES below...

How to Get the Number of Commits and Lines of Code in Pull ...

Keeping the size of your pull requests within these limits not only will speed up the review but also this amount of information...