Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Keyboard Shortcuts should be dismisable by pressing the esc key

See original GitHub issue

When opening the keyboard shortcuts via ? I want it to be dismissed when pressing the esc keybaord. I’m surprised this does not work. I think refined-github broke this since without the plugin enabled (incognito mode) this work.

Issue Analytics

State:
Created 5 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

jamiebuildscommented, Jul 18, 2018

Interestingly, <kbd>esc</kbd> already works with this modal on Safari. Seems like it might just be a bug in GitHub’s code.

1reaction

vanniktechcommented, Jul 17, 2018

Isn’t this something that we (refined-github) destroy though? If I use GitHub without any extensions I can press esc and close the dialog regardless where I’ve clicked before.

Top Results From Across the Web

Technique SCR39:Making content on focus or hover ... - W3C

Technique SCR39:Making content on focus or hover hoverable, dismissible, and persistent ... Pressing the Esc key dismisses (closes) the additional content.

Support keyboard interaction | Digital Accessibility

The easiest way to implement this is by providing a keyboard command, such as pressing the escape key, to close the content.

Changing keyboard shortcuts - Microsoft Community

Customizing keyboard shortcuts is not supported in Excel 2016. To dismiss the Help window - or most any other dialog - pressing the...

Tool tip present with 'Hover over me' button should get close ...

Per this documention, the shortcut key Esc is used for dismissing context menu. For the scenario when navigating to a control (menu item) ......

Escape key should only dismiss the topmost sheet or popup · Issue ...

Escape key should only dismiss the topmost sheet or popup #7063 ... quick access to wishlist notes, transfer functionality, and tagging keyboard shortcuts....