Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fold duplicate review threads

See original GitHub issue

Description

When you comment on a existing thread while creating a review, the comment appears in both the thread and your reviews (as a separate thread). The latter one become duplicate and potentially confusing since it loses its context.

We can try to fold these threads by default, to reduce the clutter.

Implementation-wise, we just need to look for review comments with the same [id].

Screenshot

Example URL

https://github.com//refined-github/refined-github/pull/5393#discussion_r803596694

Issue Analytics

State:
Created 2 years ago
Reactions:3
Comments:7 (7 by maintainers)

Top GitHub Comments

2reactions

cheap-glitchcommented, May 1, 2022

I’d collapse it but but much DOM do we need for that?

Very little actually, we can display a “Collapse”/“Uncollapse” text + the relevant icon with a little ::before and ::after magic. Then we make the “header” (the gray bar with the file name) clickable with a delegate and done!

0reactions

fregantecommented, May 1, 2022

Same thought, but I don’t think a duplicate label is enough. I’d collapse it but but much DOM do we need for that?