Safari: The welcome page is opened on update

Extension version

22.2.13

Browser(s) used

Safari 15.3

Description

• Since https://github.com/refined-github/refined-github/issues/5228

This should not happen on update, but apparently Safari triggers the install event even on update…

Two choices, one of which must be picked before the next release:

• exclude Safari from the current logic
• find another way to do this, maybe via the app? Or maybe better logic? Not sure if it exists.

[fregante]

How about this, in the install handler:

if (isSafari()) {
	if (!await detectFirstInstall()) {
		// Just an update #5412
		return;
	}

	// Then continue to open the first install page
}

In detectFirstInstall we check for featuresAlreadySeen and for a custom key like firstInstall. If neither is set, save firstInstall in detectFirstInstall itself to ensure this keeps working as intended even if the user has never opened the options.

Two advantages of this solution:

• Chrome users are unaffected, they don’t need firstInstall at all
• Most Safari users will be automatically migrated over, with a small minority seeing the message once

[kidonng]

• find another way to do this, maybe via the app? Or maybe better logic? Not sure if it exists.

The typical first_installation check probably works:

if (!browser.storage.sync.get('first_installation')) {
	browser.storage.sync.set('first_installation')
    window.open('https://github.com/refined-github/refined-github/issues/3543')
}

This was always an issue? Or they just broke this now?

Both (#5228 is on Dec 20, 2021)