Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Keyboard shortcut for submitting the review changes on a PR

See original GitHub issue

Edit by @fregante: this issue can be solved by following https://github.com/sindresorhus/refined-github/issues/3095

Given I’m on a PR and review the files I’d like to hit a keyboard shortcut to let me review the changes. Possibly, r could be used.

Then for accepting, rejecting, or commenting we could use a, r and c.

Shortcuts for immediately accepting / rejecting / commenting from the PR file page itself would also be nice. Maybe something like

r + a => accept
r + r => reject
r + c => comment

Issue Analytics

State:
Created 6 years ago
Reactions:1
Comments:17 (16 by maintainers)

Top GitHub Comments

4reactions

ProLosercommented, Mar 9, 2018

I don’t think it needs a distinct shortcut for comment, reject and approve. Just a shortcut to open and highlight the form after completing all inline-code comments. Once the form is focused, you can enter a message and tab to the relevant submission button.

2reactions

sindresorhuscommented, Nov 7, 2018

PR welcome 😃

For anyone that wants this, please also send this feature request to GitHub: support@github.com