Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Resolving comments

See original GitHub issue

With long threads on pull requests and issues, there’s often feedback that you’d want resolve as either taken care of or no longer relevant.

GitHub will already collapse comments on diffs that have since been updated:

<div align="center"> screen shot 2018-01-31 at 10 20 16 am

</div>

It would be awesome if we could mark any comment as “resolved” in order to clean up threads and make them easier to review later

New "resolve" button in dropdown menu

A resolved comment

</div>

In order to do this without an API from GitHub, I figure a convention could be used in the comment body.

Could you just add some tests?

#resolved

Refined GitHub could automatically collapse comments with #resolved in the body, and add a button to automatically edit the comment to tack on #resolved at the end.

Thoughts?

Issue Analytics

State:
Created 6 years ago
Reactions:19
Comments:20 (18 by maintainers)

Top GitHub Comments

3reactions

sindresorhuscommented, Jan 31, 2018

Alternatively, we could just save the comment ID as resolved in chrome.storage.local.

2reactions

fregantecommented, Jan 31, 2018

The experience for people not using Refined GitHub is improved if using the <details> strategy.

Yeah, that solution would not need an external GH App and it could be easy to implement. However I’d rather not hide the comment in a details. Maybe some thing like:

Comment marked as resolved by @thejameskyle

old comment dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.