question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Keyboard shortcuts for navigating between commits in a review don't work

See original GitHub issue

Please ensure:

  • The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.
  • The bug happens after clearing extension cache. The “Clear cache” button below can also be found at the bottom of the options page.

Example URLs

https://github.com/refined-github/refined-github/pull/5549/commits/465ee726b5681abc6e0550b9b31c7ab7aa49feae (works on any repo)

Extension version

22.3.18

Browser(s) used

Firefox 98

Description

Without Refined GitHub, when looking at an individual commit in a PR, hitting n and p on the keyboard goes to the next/previous commit.

With Refined GitHub enabled, it doesn’t work.

I’ve tried using the feature identifier within Refined GitHub to pinpoint the culprit, but when in feature detection, the issue disappears completely (which points warning-for-disallow-edits and I’m not really sure it’s related as it seems it’s mainly so because it’s the last one in the list)

No error in the JS console.

Include in this issue:

  • Screenshots/video/gif demonstrating the bug, if it’s visual
  • Console errors, if any

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:1
  • Comments:7 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
fregantecommented, May 22, 2022

Merci beaucoup Mssr. Jablon 🍕

2reactions
ewjoachimcommented, Apr 7, 2022

Woo, nice ticket number. Sharing Daft Punk vibes 🎵 🤖 ⭐ 🎸

Read more comments on GitHub >

github_iconTop Results From Across the Web

Left and right navigation to quickly go through issues ... - GitHub
The next/prev buttons on PR commits are quite easier from UX perspective ... Add keyboard shortcuts for previous/next issue navigation #152.
Read more >
Github Commit History Navigation - Stack Overflow
So, if you are looking at a particular commit, you will see several keyboard shortcuts available (under Browsing Commits ) including: p for...
Read more >
Keyboard shortcuts | Bitbucket Cloud - Atlassian Support
Keyboard shortcuts ; Pull requests ; Switch to the pull request diff tab · Switch to the pull request commits tab ; P...
Read more >
Use a screen reader to track and review changes in a ...
Navigate the changes one by one​​ You can use keyboard shortcuts to move through the tracked changes one by one. To go to...
Read more >
GitLab keyboard shortcuts
Merge requests ; Command + p, Control + p, Search for, and then jump to a file for review. ; n, Move to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found