question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`reaction-avatars` doesn't work on Discussions

See original GitHub issue

Please ensure:

  • The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.
  • The bug happens after clearing extension cache. The “Clear cache” button below can also be found at the bottom of the options page.

Example URLs

https://github.com/github/feedback/discussions/11202

Extension version

22.3.3

Browser(s) used

Chrome 99.0.4844.51

Description

Reaction avatars isn’t working on discussions.

Console error
Uncaught (in promise) DOMException: Failed to execute 'querySelector' on 'Document': '[alt="@
  
          👎
          1

"]' is not a valid selector.
    at select_dom_select (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/build/refined-github.js:1764:119)
    at chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/build/refined-github.js:6529:77
    at chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/build/refined-github.js:6544:8
    at Array.map (<anonymous>)
    at showAvatarsOn (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/build/refined-github.js:6525:90)
    at IntersectionObserver.rootMargin (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/build/refined-github.js:6557:63)

Screenshot

image

Include in this issue:

  • Screenshots/video/gif demonstrating the bug, if it’s visual
  • Console errors, if any

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:1
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
fregantecommented, Sep 30, 2022

I think GitHub changed the selectors again because the feature is completely missing from discussions now, including on 22.9.9

1reaction
cheap-glitchcommented, Mar 13, 2022

Fixing the console error is easy enough, but for some reason the avatars added to the reactions on the first comment don’t appear in the DOM, like they’re immediately nuked by GitHub or something.

Also reactions are really buggy on Discussions (this is with RGH disabled):

https://user-images.githubusercontent.com/46634000/158058802-07172479-4f2a-4ca1-b3e0-f73b8b94068f.mp4

Read more comments on GitHub >

github_iconTop Results From Across the Web

Reaction avatars not enabled for hidden items #1888 - GitHub
Successfully merging a pull request may close this issue. Fix reactions-avatars for new elements. 3 participants.
Read more >
Changes to CSS not appearing - Vanilla Forums
I made couple of changes to steamcustom.css but they do not reflect even after clearing cache.
Read more >
Refined GitHub on the App Store
Refined GitHub is a Safari extension that simplifies the GitHub.com interface and adds useful features. □ Highlights. - Linkifies issue/PR references and ...
Read more >
Penny Arcade - Ye Olde Style | Userstyles.org
Fixed font settings after forum update. 17/09/18 - Reactions now restricted to a single line. 19/08/18 - Fix for embedded tweets. 12/11/17
Read more >
Discussion of Top 10 Chrome Extensions Every Developer Likes ...
We use GitHub a lot and notice many annoyances we'd like to fix. So here be dragons. Our hope is that GitHub will...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found