Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

modify `navigate-pages-with-arrow-keys` to match GitHub's `n` / `p` keys

See original GitHub issue



I think n/p has existed for a while actually. It might make more sense to change our feature to match n/p in order to extend it to more pages. Arrows feel wrong accessibility-wise.

While I agree with the change, I did a quick test to check whether the change was feasible. p is used as a hotkey for the Project filter on issues and pull request lists. I feel that the hotkey is most used on the issues and pull request lists.

Here are 2 options that I could think of ( both after modifying the feature to match GitHub’s choice of n / p across all other supported pages ) :

  1. Maintain the arrow keys functionality for issues and pull request lists.
  2. Drop the feature for issues and pull request lists

Either way, there is going to be a feature rename and migration that would be required.

Example URLs

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:2
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

shinenelsoncommented, Aug 29, 2021

can’t we just support both?

I thought about that too after I made; but then I realized that it would not make sense ( and probably not work ) with 2 data-hotkey attributes for the same element.

fregantecommented, Sep 17, 2021

This request was addressed in the open PR, which now only renames the feature instead.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Managing deploy keys - GitHub Docs
Learn different ways to manage SSH keys on your servers when you automate deployment scripts and which way is best for you.
Read more >
Using GPG keys on GitHub: Creating and updating expired ...
Your git email address and the email address used in the GPG key should match. You can fix this particular issue by editing...
Read more >
Improving Git protocol security on GitHub
We're changing which keys are supported in SSH and removing unencrypted Git protocol. Only users connecting via SSH or git:// will be affected....
Read more >
SSH Keys for GitHub
SSH keys come in pairs, a public key that gets shared with services like GitHub, and a private key that is stored only...
Read more >
10 Set up keys for SSH - Happy Git and GitHub for the useR
Generating a key pair provides you with two long strings of characters: a public and a private key. You can place the public...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found