modify `navigate-pages-with-arrow-keys` to match GitHub's `n` / `p` keys
See original GitHub issueDescription
from https://github.com/sindresorhus/refined-github/pull/4691#issuecomment-907578663
I think n/p has existed for a while actually. It might make more sense to change our feature to match n/p in order to extend it to more pages. Arrows feel wrong accessibility-wise.
While I agree with the change, I did a quick test to check whether the change was feasible. p
is used as a hotkey for the Project filter on issues and pull request lists. I feel that the hotkey is most used on the issues and pull request lists.
Here are 2 options that I could think of ( both after modifying the feature to match GitHub’s choice of n
/ p
across all other supported pages ) :
- Maintain the arrow keys functionality for issues and pull request lists.
- Drop the feature for issues and pull request lists
Either way, there is going to be a feature rename and migration that would be required.
Example URLs
- Issue list : https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc
- Pull request list : https://github.com/sindresorhus/refined-github/pulls?q=is%3Apr+sort%3Aupdated-desc+is%3Aclosed
- Search page : https://github.com/sindresorhus/refined-github/search?q=navigat
- Commits Page :
- Releases Page : https://github.com/sindresorhus/refined-github/releases
- Notifications Page : https://github.com/notifications
- Pull Request Commits :
Issue Analytics
- State:
- Created 2 years ago
- Reactions:2
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Managing deploy keys - GitHub Docs
Learn different ways to manage SSH keys on your servers when you automate deployment scripts and which way is best for you.
Read more >Using GPG keys on GitHub: Creating and updating expired ...
Your git email address and the email address used in the GPG key should match. You can fix this particular issue by editing...
Read more >Improving Git protocol security on GitHub
We're changing which keys are supported in SSH and removing unencrypted Git protocol. Only users connecting via SSH or git:// will be affected....
Read more >SSH Keys for GitHub
SSH keys come in pairs, a public key that gets shared with services like GitHub, and a private key that is stored only...
Read more >10 Set up keys for SSH - Happy Git and GitHub for the useR
Generating a key pair provides you with two long strings of characters: a public and a private key. You can place the public...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I thought about that too after I made https://github.com/sindresorhus/refined-github/pull/4691#issuecomment-907690478; but then I realized that it would not make sense ( and probably not work ) with 2
data-hotkey
attributes for the same element.This request was addressed in the open PR, which now only renames the feature instead.