question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`quick-pr-diff-options` lightly conflicts with native "Show whitespace" button

See original GitHub issue

Please ensure:

  • The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.

Include in this issue:

  • Screenshots/video/gif demonstrating the bug, if it’s visual
  • Console errors, if any

Description

GitHub introduced a persistent “Show whitespace” (as in “whitespace changes”) setting: https://github.blog/changelog/2021-10-14-hiding-whitespace-is-now-remembered-for-each-pull-request.

quick-pr-diff-options should either hide the native button or not inject its own.

image

Example URL

https://togithub.com/refined-github/github-sandbox/pull/4/files?w=1

Browser(s) used

Firefox

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:2
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

3reactions
kidonngcommented, Oct 29, 2021

quick-pr-diff-options should either hide the native button or not inject its own.

Let’s prefer the native button if possible, while also making our button look like the native one.


I think we should reconsider this feature because the native one remembers its options while ours can’t.

Possible actions are:

  • Drop the feature
  • Build our feature on top of the native one
1reaction
cheap-glitchcommented, Nov 30, 2021

The conflict is indeed “fixed” (skipped), but our buttons ought to do better than now. Particularly the issues mentioned in the conversations above

That should probably be a new issue tagged with “enhancement”, since imo having a persistent whitespace setting is an improvement upon the existing feature.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How whitespace is handled by HTML, CSS, and in the DOM
This article explores when difficulties can occur, and looks at what can be done to mitigate resulting problems. What is whitespace? Whitespace ......
Read more >
Show whitespace characters in Visual Studio Code
Hit the F1 button, then type "Toggle Render Whitespace" or the parts of it you can remember :).
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found