Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`wait-for-build` merges without all checks completed

See original GitHub issue

Please ensure:

The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.

Include in this issue:

Screenshots/video/gif demonstrating the bug, if it’s visual
Console errors, if any

Description

I checked the Wait for successful checks checkbox, pressed the merge button and switched to another tab and window. When i switched back to the PR tab, i noticed that the PR was already merged without all of the checks completed

Console output

Example URL

https://github.com/Terrania/Baystation12/pull/29

Browser(s) used

Yandex.Browser

Issue Analytics

State:
Created 2 years ago
Comments:5 (4 by maintainers)

Top GitHub Comments

3reactions

fregantecommented, Oct 31, 2021

I think it may be time to retire the feature or switch to using the API instead, we can’t risk it go through like this.

GitHub’s new merge queue feature might be a good replacement for the feature

2reactions

kidonngcommented, Nov 1, 2021

The screenshot?

Sorry, I didn’t notice the “2 of 5 checks passed”. From your workflow file, I suppose it’s the “Maps” check (which has a matrix of 3) hadn’t passed yet when wait-for-build merged the PR.

Implementation-wise the feature just look at GitHub’s check icon, if GitHub shows the checks as passing, the we assume the checks have passed. The real problem could be what @yakov116 has described.