question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Show the applicable codeowner(s) for each file when reviewing a pull request

See original GitHub issue

Description

we’d need to parse the CODEOWNERS file and for each file in the PR, take the applicable codeowners.

note that there might be multiple ones that apply. I initally thought that displaying the codeowner in the top column of the file, e.g. next to “Viewed” checkbox, or next to the filename itself might make sense, but now not sure since we don’t want to clutter. maybe would make sense to show the codeowner if it’s only 1, and if there’re multiple ones - show a preview of the avatars, and allow clicking on them to expand.

this would be useful for reviewing - a bigger project is owner by multiple teams, or just different people, and its common when someone asks for a review in slack to cc the main codeowners to get the pr reviewed faster.

Screenshot

No response

Example URL

https://github.com/refined-github/refined-github/pull/3/files

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

3reactions
kidonngcommented, Oct 11, 2021

Isn’t that already the case? Example: https://togithub.com/NixOS/nixpkgs/pull/141261/files

image

2reactions
kidonngcommented, Oct 14, 2021

I assume the question is answered, if that’s not what you asked please reply with more details (or better, with a mockup).

Read more comments on GitHub >

github_iconTop Results From Across the Web

About code owners - GitHub Docs
For code owners to receive review requests, the CODEOWNERS file must be on the base branch of the pull request. For example, if...
Read more >
Code Owners - GitLab Docs
Each Code Owner in the merge request widget is listed under a label. The following image shows a Groups and Documentation section:.
Read more >
How We Tamed GitHub CODEOWNERS With Bots - FullStory
Whenever a pull request is opened, GitHub will automatically check all changed files; for each that matches a codeowners rule, the owners ...
Read more >
How to limit Github codeowners file to specific branches only?
You can enforce pull request reviews from CODEOWNERS based on branches. In your Repo, Go to: Settings -> Branches -> Add Rule ->...
Read more >
Github: How to auto request PR reviews ( Code Owners for ...
How to automatically request Pull Request reviews from a specific user when a new pull request is created. This tutorial utilises codeowners ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found