Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ItemAPI CustomItem uses ItemDef.tier

See original GitHub issue

Right now, two of the overloaded constructors for CustomItem in ItemAPI.cs set the item tier using ItemDef.tier.

I believe this is problematic since tier is a property whose setter requires ItemTierCatalog.Init() to have occurred first Otherwise, it’ll be set to null which means the getter falls back to deprecatedTier which defaults to ItemTier.Tier1

Is this something we want to fix for ItemAPI and change to deprecatedTier or are we still finding a better permanent workaround to ensure the Init() has occurred first? Unless I’m misunderstanding and R2API already does something to combat this?

Issue Analytics

State:
Created a year ago
Comments:6 (5 by maintainers)

Top GitHub Comments

1reaction

Nebby1999commented, Apr 25, 2022

Upstream as in Risk of Rain 2 proper, sorry.

Because this is a non issue on Unity editor development, because you set the tier directly via the itemTierDef field

This issue is exclusively when it comes to visual studio only mods, thunderkit also doesn’t have this issue due to being almost identical to hopoo’s development enviroment

1reaction

Nebby1999commented, Apr 23, 2022

I just posted a PR #394 to fix this

Top Results From Across the Web

Item Tiers - MythicCraft

By default, tiers are Trash, Common, Uncommon, Rare, Very Rare, Legendary, Mythical, Epic, Magical and Unique. You can edit the tiers in the...

REST API for Content Management - Creates an Item

Creates an item with the given payload. Creates master/variations of content items or variations of digital assets if file sharing option is enabled...

GetItem - API Reference

Item ItemType Always Item.ApplicationData string Cond... Item.ApplyBuyerProtection BuyerProtectionDetailsType Cond... Item.ApplyBuyerProtection .BuyerProtectionSource BuyerProtectionSourceCodeType Cond...

AddItem - API Reference - Trading API

Item ItemType Required Item.ApplicationData string Optional Item.AutoPay boolean Optional Item.BestOfferDetails BestOfferDetailsType Optional

Web API design best practices - Azure Architecture Center

Here are some of the main design principles of RESTful APIs using HTTP: REST APIs are designed around resources, which are any kind...