sap.m.Tree - JsonModel - Filter - arrayNames

OpenUI5 version: Detected in 1.48, but presumably in all versions since 1.44

Browser/version (+device/version): All browsers and devices

URL (minimal example if possible): https://embed.plnkr.co/bCOxJgLiQ6YRgKjhMsdq/

Steps to reproduce the problem: If you create hierachical json model with arrays

new JSONModel([ {key:"node1", text:"bla", children:[...]},
                       {key:"node2", text:"moo", children:[...]} ]

and you assign this to a Tree: items:{path:'/', parameters{ arrayName:['children']} } Filtering won’t work anymore.

The reason fir this lies in the ClientTreeBinding method getNodeContexts

If your node is an array “aChildArray = oNode[sArrayName];” will not work. this assumes that your model is a hierarchical object, instead of an array.

if however you could add

if(oNode instanceof Array){
  oNode.forEach(function(oItem){
  aChildArray = oItem[sArrayName];
  ...
})

Than filtering would also work on Array based json models.

[FiddleBe]

Ahh, so if the node IS an array, you first store the subcontext of the node itself, and then recursively process each item in the array. that’s an elegant fix. and it solves my (non-prio) issue of having duplicate subcontexts

a second issue I faced after posting my proposal, was the iSizeLimit. I had a tree with 200 items, and apparently there’s a default iSizeLimit of 100. I overcame that issue by setting the iSizeLimit directly on my model to 99999. But wouldn’t it be better if there was a parameter that let’s you ignore any sizelimit? (eventhough I agree that performance can be severly affected)

Thanks for taking this up

PS: can you also update the doco of the sap.m.tree with the parameters? I only found out about them by diving deep into the debug-code.

PPS: if a patch can be made available for 1.46, 1.48, 1.50 and up, that would be great! We have a couple of projects still on 1.46 because of compatibility issues

[vdhnils]

this problem still seems to be happening in SAPUI5… i can solve it by applying filtering from the controller instead of the view… (in the view the filter has no effect, due to arrayNames)

			oOutcomeTreeTable.getBinding("rows").filter(
				new Filter({
			        path: "_sOperation",
			        operator: "NE",
			        value1: "DELETE",
			    })
			);